used ephemeral response in question transfer #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taz03
added
enhance command
ankitsmt211
reviewed
Nov 21, 2023
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
ankitsmt211
requested changes
Nov 21, 2023
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Nov 21, 2023
Member
Zabuzard
left a comment
Zabuzard
left a comment
There was a problem hiding this comment.
this needs a deferReply(true) and then reply through the hook.
as its not all-in-the-code but based on an external discord api request (retrieveUserById) and anything that goes over the wire is bound to take too long.
Member
|
Actually nope, forgot to check the most important part. Simultaneous transfers, the interaction is already consumed. Why do i feel like going back to square one👀? could be reason why i went with not an ephemeral one. |
Member
|
Oki figured this out, everything looks solid . It still has a chance to create two threads, if the transfer submission is too close because message OP's message still being available. |
|
Kudos, SonarCloud Quality Gate passed! |
Zabuzard
requested changes
Nov 22, 2023
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Show resolved
Hide resolved
Zabuzard
approved these changes
Nov 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
response when already transferred by someone else:
response on transfer:
